refactor: refactored get_http_dir #360
Open
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bash syntax error in the get_http_dir() function that was preventing the script from executing properly on certain bash versions. The original code used bash array syntax that was causing parsing errors.
- Simplified the bash script logic by replacing array-based parsing with grep and awk
- Updated module version from 1.2.2 to 1.2.3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| registry/coder/modules/kasmvnc/run.sh | Refactored get_http_dir function to use grep+awk instead of bash arrays |
| registry/coder/modules/kasmvnc/README.md | Updated version number to reflect the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
The awk-based YAML parsing improvement needed proper escaping of field references as 2936092 so Terraform's templatefile() function processes them correctly. This resolves template syntax errors that were causing the DateTime.pm installation failures.
DevelopmentCats
force-pushed
the
patch-1
branch
from
0ff098c to
74abeac
Compare
matifali
approved these changes
Oct 1, 2025
…or Ubuntu 24.04 bug
|
@matifali I noticed a bug with ubuntu 24.04 so I added something small to resolve that. This is tested and working. Once you approve I will go ahead and release it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description
I just couldn't get the script to execute properly in its current form. I saw e.g.
[[: 1989{#d[@]}: syntax error: invalid arithmetic operator (error token is "{#d[@]}")when trying to run the script locally. (GNU bash, version 5.2.21(1)-release (x86_64-pc-linux-gnu)).
This uses a likely simpler bash script, but requires both grep and awk.
Type of Change
Module Information
Path:
registry/coder/modules/kasmvncNew version:
v1.2.3Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues